Prevent rank display shown in skin editor toolbox from playing samples #33503
Conversation
Because some people don't seem to like it. Defaults to on still.
| @@ -45,6 +51,9 @@ private void load() | |||
| RelativeSizeAxes = Axes.Both | |||
| }, | |||
| }; | |||
|
|
|||
| if (skinEditor != null) | |||
There was a problem hiding this comment.
I guess the alternative (which I would have chosen personally) is resolving Player. I'm probably fine with both, but did you consider this one?
There was a problem hiding this comment.
As in, you mean inverting this logic and attempting to resolve Player and disabling playback if it's null?
That won't work because of the reason I already mentioned in the OP:
Trying basically any solution with DI runs against the problem that the dependencies are borrowed wholesale from the screen that the component is supposed to work in
Player will successfully resolve even if the display is being shown in the toolbox because of this borrowing.
There was a problem hiding this comment.
I see.
Let's stick with this for now. Only other thing I'd propose is a dedicated interface, but we can adjust if there's more usages of this.
fd3514c to
e02cd28
Compare
Add toggle for rank change sound playback to default rank display
Because some people don't seem to like it. Defaults to on still.
Prevent rank display shown in skin editor toolbox from playing samples
Closes #33456.
Not sure how to feel about that change but I don't see many other alternatives. Trying basically any solution with DI runs against the problem that the dependencies are borrowed wholesale from the screen that the component is supposed to work in, so trying things like implementing
ISamplePlaybackDisableronSkinEditorjust straight up fails because resolving via that interface from toolbox buttons returnsPlayerand notSkinEditor.