Skip to content

Add confirmation step before blocking a user #33606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2025

Conversation

peppy
Copy link
Member

@peppy peppy commented Jun 10, 2025

Closes #33585.

Copy link
Collaborator

@bdach bdach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow this blocking functionality is half-assed. only available from user panels? not available from right clicking on users in chat? not available from user profiles?

this works for what this set out to be though so I'm just going to pretend I saw none of that

@peppy
Copy link
Member Author

peppy commented Jun 10, 2025

Right? Also I don't think you can ever unblock, since blocking hides the user card.

Gravely needs to be on user profiles as well, at very least.

@bdach bdach merged commit 4dcc928 into ppy:master Jun 10, 2025
7 of 9 checks passed
@peppy peppy deleted the add-confirmation-for-block branch June 11, 2025 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blocking users needs a dangerous action popup
2 participants