Skip to content

Rewrite and add commentary to selection debounce logic #33879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2025
Merged

Rewrite and add commentary to selection debounce logic #33879

merged 1 commit into from
Jun 25, 2025

Conversation

peppy
Copy link
Member

@peppy peppy commented Jun 25, 2025

Hopefully a bit easier to maintain going forward? Not sure.

@peppy
Rewrite and add commentary to selection debounce logic
49a9652 
Hopefully a bit easier to maintain going forward? Not sure.
@peppy peppy requested a review from bdach June 25, 2025 09:00
bdach
bdach approved these changes Jun 25, 2025
View reviewed changes
Copy link
Collaborator

@bdach bdach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure. going to trust tests for correctness (the only actual change is the reordering of the cancellation in SelectAndRun() which does seem more correct to my untrained eye)

@bdach bdach merged commit 5c00985 into ppy:master Jun 25, 2025
9 checks passed
@peppy peppy deleted the selection-debounce-refactor branch June 30, 2025 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdach bdach bdach approved these changes

Assignees
No one assigned
Labels
size/M type:code-quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peppy @bdach