Fix player settings no longer collapsing correctly #33958
Merged
+25
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regressed with ppy#33621 for obvious reasons. Tachyon doing its job, caught this before hitting a proper release.
bdach
approved these changes
Jun 30, 2025
|
|
||
| [BackgroundDependencyLoader] | ||
| private void load() | ||
| { | ||
| InternalChild = CreateScrollContainer().With(s => |
There was a problem hiding this comment.
all I will say to my defense is that the only reason I accepted any of this as weirdly as it was written, was to avoid a virtual member call in ctor, which you have railed against several times in the past. and no, it's not a "technically fine" one in this context, either, because
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regressed with #33621 for obvious reasons. Tachyon doing its job, caught this before hitting a proper release.
Closes #33950.