Skip to content

Display user avatar and content in chat notifications, also display avatar in friend presence notifications #34001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

frenzibyte
Copy link
Member

@frenzibyte frenzibyte commented Jul 3, 2025

I wanted to split each change into its own PR, but that causes stupid dependency chains to occur. So instead, I've grouped everything in this PR, and I'll scratch out any change that's not good.

Before After
CleanShot 2025-07-03 at 11 26 36 CleanShot 2025-07-03 at 12 12 17

CleanShot 2025-07-03 at 11 45 30
CleanShot 2025-07-03 at 11 45 19

When many users become online/offline at once, the old design is still retained:

CleanShot 2025-07-03 at 11 56 26

@peppy
Copy link
Member

peppy commented Jul 4, 2025

Please match osu-web design:

Safari 2025-07-04 at 11 26 43

Copy link
Member

@peppy peppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I already said this should match web so I'm not sure why it doesn't.

@frenzibyte
Copy link
Member Author

I'm not quite sure where have you said that. I will match it though.

@peppy
Copy link
Member

peppy commented Jul 4, 2025

I'm not quite sure where have you said that. I will match it though.

#33945 (comment)

@frenzibyte
Copy link
Member Author

I'm confused, you're talking about design here, but the issue thread you linked there seems to be about...hooking up web notifications into lazer? I don't understand the relation.

@peppy
Copy link
Member

peppy commented Jul 4, 2025

You're implementing something bypassing the larger task, which is to make notifications match osu-web.

If you're going to bypass that task, then at very least make them look the same. So we don't have to redo the redo again and again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants