Fix fenced code block syntax highlighting#534
Merged
Conversation
* added support for tilde `~` fenced code blocks * added support for arbitraty length code block fences
Contributor
Author
|
As per CommomMark Spec, fenced code blocks can be written using either 3 or more This pull request fixes this behavior, and also allows the code block fences themselves to be of an arbitrary length while maintaining syntax highlighting. |
alerque
requested changes
Apr 13, 2022
alerque
left a comment
Member
There was a problem hiding this comment.
I preliminary review of this looks solid to me. Would you by chance be around to either rebase on master or merge from master and resolve the merge conflicts?
Contributor
Author
|
Just merged it. Can you check if it's ok? EDIT: Just fixed a vint workflow error that I didn't notice. |
Fix the following error: Use robust operators `!~#` or `!~?` instead of `!~`
alerque
approved these changes
Apr 26, 2022
Member
|
Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
~fenced code blocks