Add SQL Server locking support (table-based and session-based) #1014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a complete locking mechanism for SQL Server, similar to the existing PostgreSQL implementation from PR pressly#993. Features: - Table-based locking using MERGE for atomic upserts - Session-based locking using sp_getapplock/sp_releaseapplock - Automatic lease renewal via heartbeat mechanism - Stale lock cleanup for expired leases Implementation: - lock/internal/store/sqlserver.go: LockStore implementation - lock/sqlserver.go: Public API (NewSqlserverTableLocker, NewSqlserverSessionLocker) - internal/testing/testdb/sqlserver.go: Docker test helper - SQL Server specific test migrations - Comprehensive integration tests for both locking modes The table-based locker uses SQL Server's MERGE statement with HOLDLOCK for atomic lock acquisition and SYSUTCDATETIME() for server-side time. The session-based locker uses SQL Server's built-in application lock stored procedures which provide session-level advisory locking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a complete locking mechanism for SQL Server, similar to the existing PostgreSQL implementation from PR #993.
Features:
Implementation:
The table-based locker uses SQL Server's MERGE statement with HOLDLOCK for atomic lock acquisition and SYSUTCDATETIME() for server-side time. The session-based locker uses SQL Server's built-in application lock stored procedures which provide session-level advisory locking.