Skip to content

Log SQL query results if supported by DB (rows affected, last insert ID) #944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
obaltian wants to merge 8 commits into
base: main
Choose a base branch
from
+109 −6
Open

Log SQL query results if supported by DB (rows affected, last insert ID) #944

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b3d1e91
log query results (now only in CLI mode)
obaltian May 14, 2025
c93503d
rename func
obaltian May 14, 2025
2ba9850
fix typo
obaltian May 14, 2025
32768a7
fix leading comma issue
obaltian May 15, 2025
7254a9c
provider_run: log sql.Result
obaltian May 15, 2025
d4b76a5
Merge branch 'pressly:main' into log-query-result
obaltian Aug 13, 2025
7a16a66
Remove extra empty lines
obaltian Aug 13, 2025
06d99b4
Fix golangci-lint issue in unit test
obaltian Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix golangci-lint issue in unit test
  • Loading branch information
@obaltian
obaltian committed Aug 13, 2025
commit 06d99b4a6b1f3f1287f40c7adb2e7abfbc71bd63
2 changes: 1 addition & 1 deletion internal/gooseutil/sql_logging_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ func TestFormatSQLResultInfo(t *testing.T) {

// Nothing supported
got := FormatSQLResultInfo(nothingSupportedRes)
require.Equal(t, "", got)
require.Empty(t, got)

// Both supported
got = FormatSQLResultInfo(bothSupportedRes)
Expand Down