-
Notifications
You must be signed in to change notification settings - Fork 619
Add duckdb support as optional #996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
bligneri
wants to merge
17
commits into
pressly:main
Choose a base branch
from
bligneri:add-duckdb-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+434
−117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wth no duckdb support)
…r binary (no debug symbol and an option for compression)
…clearer README with the updated info.
Collaborator
|
When we get around to this, the Go driver (still CGO) moved to https://github.com/duckdb/duckdb-go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
I understand DuckDB support was removed due to CGo dependencies and binary size concerns.
Since I need DuckDB support for a few projects, I'm proposing a different approach: opt-in support via build tags. This means:
duckdbtagBuild Options
Three Makefile targets are provided for DuckDB builds:
make build-duckdb- full binary with debug symbols (~97MB)make build-duckdb-nodebug- stripped binary (~73MB)make build-duckdb-nodebug-compressed- UPX compressed (~18MB)Binary Size Comparison (x86_64)
For the compression I used
upxand the results are interesting for em.Implementation
internal/dialects/duckdb.go//go:build duckdbensures opt-in onlymake test-duckdb)This approach allows DuckDB users to benefit from goose without impacting the default build for everyone else.