Rename default shader methods to have a base* prefix#7288
Merged
Conversation
perminder-17
approved these changes
Sep 24, 2024
Collaborator
perminder-17
left a comment
There was a problem hiding this comment.
Looks good, also works well. Thanks for your work!
davepagurek
added a commit
that referenced
this pull request
Sep 24, 2024
Rename default shader methods to have a base* prefix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #7256 we realized that the shader hooks methods, like
strokeShader()to augment the default stroke shader, would clash with the methodstrokeShader(yourShader)to override what shader is used to draw strokes.This renames the shader hook methods to have a
base*prefix. So,baseStrokeShader()returns our default shader to modify, leaving us free to havestrokeShader(yourShader)still set the active stroke shader.