fix: Correct typo, improve createRadio() method description, and simplify input tag#7315
Conversation
|
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. And be sure to add yourself to the list of contributors on the readme page! |
|
@davepagurek Could you please review this PR? All required changes have been made, and I’m awaiting your feedback for the merge. |
|
@Dhanush111 not sure why you tagged me in this issue as I'm not part of the collaborators here? |
perminder-17
left a comment
There was a problem hiding this comment.
Since you're working on fixing the createRadio() method, could you also adjust the examples? Currently, the options are not displaying correctly.
I believe this can be resolved by applying some styling to myRadio, perhaps by setting display: flex and flex-direction: column.
| * - `myRadio.selected()` returns the currently-selected option. | ||
| * - `myRadio.selected(value)` selects the given option and returns it as an <a href="https://developer.mozilla.org/en-US/docs/Web/API/HTMLInputElement" target="_blank">`HTMLInputElement`</a>. | ||
| * - `myRadio.disable(shouldDisable)` enables the entire radio button if `true` is passed and disables it if `false` is passed. | ||
| * - `myRadio.disable(shouldDisable)` Disables the radio button if `true` is passed, and enables it if `false` is passed. |
|
@perminder-17 Yes, i too saw those things were not right, the thing is, I’m having trouble running it locally or on GitHub Pages right now, so I can’t make those changes myself at the moment. |
perminder-17
left a comment
There was a problem hiding this comment.
No problem, I will open up a PR on fixing this very soon.
| @@ -0,0 +1,51 @@ | |||
| # Sample workflow for building and deploying a Jekyll site to GitHub Pages | |||
| name: Deploy Jekyll with GitHub Pages dependencies preinstalled | |||
There was a problem hiding this comment.
Sorry if I am unable to understand, but can you help me knowing what's the use of adding this file?
There was a problem hiding this comment.
@perminder-17 sorry, it was accidental(tried to build it on github using that file)
perminder-17
left a comment
There was a problem hiding this comment.
Sorry for the delay in review, looks good to me.
Related Issue
Originally reported in p5.js-website repository: #595 - Misspelling in Docs: Reference > createRadio()
Summary
myRadio.option()method.myRadio.disable()method for better clarity:to "Disables the radio button if true is passed, and enables it if false is passed."
<input name="food"></input>to<input name="food">since<input>is self-closing.Motivation
These updates improve the clarity, accuracy, and HTML standards compliance of the createRadio documentation, making it easier for developers to understand and implement this method.
Additional Notes
Please review the changes to ensure they align with the documentation style and standards of the project.