fixed repeated key presses when a modifier key is held#7435
Conversation
|
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. And be sure to add yourself to the list of contributors on the readme page! |
davepagurek
left a comment
There was a problem hiding this comment.
I think these changes look good to merge, thank you @Rishab87!
Next time, we ask that you wait to be assigned to an issue before filing a PR, as for this one someone else had been assigned. Our contributor docs mention:
You should not "jump the queue" by filing a PR for an issue that either someone else has indicated willingness to submit a contribution or has already been assigned to someone else.
@davepagurek sure thing! I'll keep that in mind from next time! |
Resolves #7282
Changes:
As @davepagurek proposed above, I have used .repeat check to make sure we can capture repeated presses and recording which keys were pressed in combination with the meta key, and then when the meta key is released, manually update _downkeys so that they're all set to false
Screenshots of the change:
PR Checklist
npm run lintpasses