Skip to content

Fix buildGeometry absorbing the ambient fill color#7489

Merged
davepagurek merged 1 commit into
dev-2.0from
fix/geom-default-color
Jan 22, 2025
Merged

Fix buildGeometry absorbing the ambient fill color#7489
davepagurek merged 1 commit into
dev-2.0from
fix/geom-default-color

Conversation

@davepagurek
Copy link
Copy Markdown
Contributor

Changes:

  • An intended change in 2.0 was to make it so that when you call model() on a shape made in buildGeometry, it will take on whatever the fill colour currently is, unless you manually set a fill color within buildGeometry.
  • This functionality stopped working after we changed how the renderers manage their fill/stroke color
  • This restores the expected behaviour.

@davepagurek davepagurek merged commit c7ee241 into dev-2.0 Jan 22, 2025
@davepagurek davepagurek deleted the fix/geom-default-color branch January 22, 2025 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant