Skip to content

Add support for Reclass inventory queries #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
simu wants to merge 22 commits into
base: main
Choose a base branch
from
Draft

Add support for Reclass inventory queries #168

simu wants to merge 22 commits into from

Conversation

@simu
Copy link
Member

@simu simu commented May 20, 2025 •
edited
Loading

Checklist

  • The PR has a meaningful title. The title will be used to auto generate the changelog
  • PR contains a single logical change (to build a better changelog).
  • Update the documentation.
  • Update tests.
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency, internal
    as they show up in the changelog
  • Link this PR to related PRs or issues.

TODO

  • Look at performance
  • Add more test coverage
  • Add Python test coverage which compares to Python reclass

@simu simu added the enhancement New feature or request label May 20, 2025
@simu simu marked this pull request as draft May 20, 2025 14:00
@github-actions

This comment was marked as outdated.

Sign in to view
@simu simu force-pushed the feat/inventory-queries branch from 6467a45 to 99dad9e Compare May 20, 2025 14:04
@github-actions

This comment was marked as outdated.

Sign in to view
@github-actions

This comment was marked as outdated.

Sign in to view
@simu simu force-pushed the feat/inventory-queries branch from ae043d7 to 011da57 Compare September 19, 2025 09:20
@github-actions

This comment was marked as outdated.

Sign in to view
@github-actions

This comment was marked as outdated.

Sign in to view
@simu simu force-pushed the feat/inventory-queries branch from 6a0d9f1 to ed5dfd0 Compare September 19, 2025 09:51
@github-actions
Copy link

github-actions bot commented Sep 19, 2025

Benchmark for b794977

Click to view benchmark
Test Base PR %
Reclass::inventory() multi-threaded 1708.0±49.08µs 2.0±0.16ms +17.10%
Reclass::inventory() single-threaded 3.6±0.02ms 3.6±0.05ms 0.00%

simu and others added 19 commits September 19, 2025 15:26
@simu
Fix flaky buildinfo test
30db908 
buildinfo test can fail for a while after new rust version is released
and the rust version on the CI runners isn't updated yet.
@simu
Implement basic parsing and merging for field exports
3de6e65 
This doesn't yet implement inventory queries in the reference parser and
the interpolation. Also, the interpolation order between parameters and
exports is currently a guess.
@simu
Extend ref parser to also parse inv queries
9658e53
@simu
Add impl notes
51d6a29
@simu
Possible skeleton for inventory queries
671c180 
The approach of only parsing inventory queries after resolving
references probably won't work, since we don't know whether a query was
escaped or not at that point.

To do this properly, we'll have to extend / refactor the ref parser to
become a ref+invquery parser.
@simu
Disable broken export resolver impl
c3bd317
@simu
Pre-render global exports and pass through for parameter resolution
3aa57a1
@simu
Partial implementation for query execution
8625208
@simu
Initial implementation for parsing and evaluating inventory queries
aa3ff1f 
Test coverage isn't great yet, and some inventory query features are not
yet implemented.
@simu
Add test inventory for inv queries
1596cd3
@simu
Introduce Exports type
d60fd6a
@simu
Treat inventory queries the same as references in Token::render()
df3f880
@simu
Adjust inventory query execution exports access
a7afc0b
@simu
Add test assertions for the inv-queries inventory test case
3d961a5
@simu
Cleanup duplicated data and update inventory query evaluation
e99b652
@simu
Clean up clippy warnings
4bd8e01
@simu
Refactor to render exports when resolving queries and commit `src/exp…
94cd20d 
…orts.rs`
@simu
Update inventory query execution to handle IgnoreErrors the same as p…
44d8534 
…yreclass

Not validated yet
@simu
Remove unnecessary +IgnoreErrors in inv-query test inventory
6105359
simu added 3 commits September 19, 2025 16:47
@simu
Make node parsing in Exports::new() multi-threaded
c68adc8 
Without this, `Exports::new()` has a very significant performance impact
even for inventories that don't use inventory queries at all.
@simu
Make hidden lifetime explicit
c2a7f81
@simu
remove dbg!() and disable eprintln!() in release mode
c5989cb
@simu simu force-pushed the feat/inventory-queries branch from ed5dfd0 to c5989cb Compare September 19, 2025 14:49
@github-actions
Copy link

github-actions bot commented Sep 19, 2025

Benchmark for 7219478

Click to view benchmark
Test Base PR %
Reclass::inventory() multi-threaded 1746.1±127.34µs 2.0±0.15ms +14.54%
Reclass::inventory() single-threaded 3.5±0.02ms 3.7±0.22ms +5.71%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@simu