Repository navigation
Conversation
Since pybind11_protobuf uses pybind11_abseil only in its internal tests,
we can treat it as a dev_dependency. This helps to avoid diagnostics
from newer versions of rules_python as follows:
DEBUG: /private/var/tmp/_bazel_phawkins/2c4ae1b95137b6eaec60bd8deca2f50d/external/rules_python+/python/private/pypi/extension.bzl:396:26: WARNING: The PyPI hub name 'pypi' is reserved (module 'pybind11_abseil'). Please rename your hub, otherwise a future release will rename it to 'pybind11_abseil_pypi'.
This fix has landed in pybind11_abseil in
pybind/pybind11_abseil@65c170c
but there has been no new release of pybind11_abseil in the Bazel
Central Registry that includes this fix.
Collaborator
|
FYI we are working hard to bring pybind_abseil up to date and soon provide a new release... |
Author
I'm delighted to hear it! Still, since pybind_protobuf consumes pybind_abseil only for internal testing, it seems reasonable to make it a dev_dependency. Do you agree? |
Author
|
Since the change I'm proposing here pertains only to Bazel, I strongly suspect the CMake CI failures are unrelated to my changes. |
dws
marked this pull request as ready for review
November 6, 2026 16:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since pybind11_protobuf uses pybind11_abseil only in its internal tests, we can treat it as a dev_dependency. This helps to avoid diagnostics from newer versions of rules_python as follows:
This fix has landed in pybind11_abseil in
but there has been no new release of pybind11_abseil in the Bazel Central Registry that includes this fix.