Skip to content

Conversation

@alexmojaki
Copy link
Contributor

Closes #1334

@cloudflare-workers-and-pages
Copy link

Deploying logfire-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 553d25b
Status: ✅  Deploy successful!
Preview URL: https://ba40154c.logfire-docs.pages.dev
Branch Preview URL: https://alex-commenter.logfire-docs.pages.dev

View logs

@alexmojaki alexmojaki requested a review from Copilot August 20, 2025 12:42
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the enable_commenter and commenter_options arguments in the instrument_sqlalchemy function to ensure they are properly passed through to the underlying SQLAlchemy instrumentor.

  • Fixes the instrument_sqlalchemy function to pass through enable_commenter and commenter_options parameters
  • Adds comprehensive test coverage to verify the commenter functionality works correctly

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
logfire/_internal/integrations/sqlalchemy.py Fixed the function to properly pass enable_commenter and commenter_options to the SQLAlchemy instrumentor
tests/otel_integrations/test_sqlalchemy.py Added new test case to verify commenter functionality and imported SQLite3Instrumentor for proper cleanup

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@alexmojaki alexmojaki merged commit d6e6077 into main Aug 20, 2025
14 checks passed
@alexmojaki alexmojaki deleted the alex/commenter branch August 20, 2025 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

instrument_sqlalchemy enable_commenter has no effect

2 participants