Support logfire.instrument without arguments

[Kludex]

• Closes @logfire.instrument should work in bear mode #537

[cloudflare-workers-and-pages]

Deploying logfire-docs with    Cloudflare Pages

Latest commit:	1fd9012
Status:	✅  Deploy successful!
Preview URL:	https://20ab6e74.logfire-docs.pages.dev
Branch Preview URL:	https://support-instrument-parametre.logfire-docs.pages.dev

View logs

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (267c83a) to head (1fd9012).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##              main      #607   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          133       133           
  Lines        10541     10549    +8     
  Branches      1448      1450    +2     
=========================================
+ Hits         10541     10549    +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

---

🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests

[alexmojaki]

Suggested change

	def instrument(self, msg_template: Callable[P, R]) -> Callable[P, R]: ...
	def instrument(self, func: Callable[P, R]) -> Callable[P, R]: ...

[Kludex]

This is not possible. The parameter names must match.

[alexmojaki]

Suggested change

	msg_template: Callable[P, R] | LiteralString | None = None,
	msg_template_or_func: Callable[P, R] | LiteralString | None = None,

[Kludex]

I didn't do what the suggestions suggest because it's a breaking change... People could be doing msg_template=....

Or do you want to add the /?

[alexmojaki]

OK leave the main signature as is but use the name func in the overload and silence pyright about it.

[Kludex]

OK leave the main signature as is but use the name func in the overload and silence pyright about it.

The problem is the typing issue is not on the overload method, but on the main function itself... i.e. I'll have to type: ignore the main function.

We may make typing mistakes in the instrument without noticing if we do this.

[alexmojaki]

What if you just ignore that specific error code?

[Kludex]

What if you just ignore that specific error code?

I'm not sure if this is working as expected, but done.