Add capture_response_body and capture_request_body to httpx
#769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying logfire-docs with
|
| Latest commit: |
556bf49
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://de8fa95a.logfire-docs.pages.dev |
| Branch Preview URL: | https://add-capture-request-body-and.logfire-docs.pages.dev |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #769 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 137 137
Lines 10925 10873 -52
Branches 781 772 -9
=========================================
- Hits 10925 10873 -52 ☔ View full report in Codecov by Sentry. |
alexmojaki
reviewed
Jan 3, 2025
alexmojaki
reviewed
Jan 3, 2025
alexmojaki
reviewed
Jan 3, 2025
b93f416 to
208f3aa
Compare
alexmojaki
reviewed
Jan 6, 2025
| @cached_property | ||
| def text(self) -> str: | ||
| return decode_body(self.content, self.content_type_charset) | ||
| return self.content.decode(self.content_type_charset) |
Contributor
There was a problem hiding this comment.
Please inline this property, it's now simple enough that it's not useful to users, the fact that it can raise errors can surprise users, and it doesn't actually need to be cached.
alexmojaki
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.