Skip to content

Show more digits of step size in progress_bar #7870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2025

Conversation

ricardoV94
Copy link
Member

@ricardoV94 ricardoV94 commented Jul 24, 2025

The two digits was copied from nutpie according to @jessegrabowski. I noticed that we always have a 0.0x, so it's not very useful. @aseyboldt explained that something something pymc nuts considers small eigenvalues of the matrix, while nutpie ignores it, which means our step-sizes tend to be smaller.

This PR adds one extra digit for me to look at.


📚 Documentation preview 📚: https://pymc--7870.org.readthedocs.build/en/7870/

@jessegrabowski
Copy link
Member

We might want to consider increasing the width of the Rich console, so we have a bit more real estate to show all these digits.

@ricardoV94 ricardoV94 merged commit dc7cfee into pymc-devs:main Jul 24, 2025
25 checks passed
Copy link

codecov bot commented Jul 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.90%. Comparing base (5d4c33c) to head (dda00cc).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7870      +/-   ##
==========================================
- Coverage   92.94%   91.90%   -1.05%     
==========================================
  Files         116      116              
  Lines       18845    18845              
==========================================
- Hits        17516    17319     -197     
- Misses       1329     1526     +197     
Files with missing lines Coverage Δ
pymc/step_methods/hmc/nuts.py 97.61% <ø> (ø)

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ricardoV94
Copy link
Member Author

The width isn't dynamic?

@ricardoV94 ricardoV94 deleted the progress_bar_digits branch July 24, 2025 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants