Stop seeding wheel for pyodide venv - #208
Merged
Merged
Conversation
wheel for pyodide venv
agriyakhetarpal
marked this pull request as ready for review
May 20, 2025 09:39
Member
Author
|
Merging this for now as it's a trivial bug fix and doesn't add any new code. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
--wheel/--no-wheeloptions for were first removed frompypa/virtualenvin pypa/virtualenv#2868, added back in pypa/virtualenv#2876, and both PRs were released in https://github.com/pypa/virtualenv/releases/tag/20.31.0. These were then reintroduced in pypa/virtualenv#2884 via https://github.com/pypa/virtualenv/releases/tag/20.31.2, but are present only when usingvirtualenvon Python 3.8 and earlier versions, and don't show up in the CLI--helpon later versions altogether as there is no effect. As we support Python >=3.12, we should be fine with dropping this option completely. I've also added a minimum bound forvirtualenv, and we should be fine with dropping the option as I don't think anyone was using it anyway.I noticed this as some of the integration tests have been failing on
mainand weren't caught because we didn't need to run them on the last few PRs.