Clarify warning for incompletely removed distributions#14047
Open
2ykwang wants to merge 4 commits into
Open
Conversation
Member
|
Hi @2ykwang, thanks for the contribution! |
Contributor
Author
|
Thanks @sepehr-rs appreciate it. no rush! |
2ykwang
force-pushed
the
clarify-leftover-warning
branch
from
June 12, 2026 16:19
522c0f3 to
9d4f429
Compare
2ykwang
force-pushed
the
clarify-leftover-warning
branch
from
June 12, 2026 16:30
9d4f429 to
153a445
Compare
sepehr-rs
approved these changes
Jun 14, 2026
Member
There was a problem hiding this comment.
Thank you for your contribution!
I tested this locally and the new warning message is more user-friendly. The tests look good too.
I do have one comment on the leftover_name logic that's worth addressing for future releases. Besides that, LGTM from me!
Let me know if you have any questions.
ichard26
self-requested a review
June 20, 2026 20:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11849.
add a distinct warning for
~-prefixed leftovers, marking them as incompletely removed and safe to delete.the check uses the metadata directory name instead of the distribution name, since pkg_resources (default on 3.10) turns the leading
~into-. Open to a different approach.output: