gh-136327: Fix inconsistent TypeError messages regarding invalid values after * and ** #136395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All commit authors signed the Contributor License Agreement. |
sobolevn
reviewed
Jul 7, 2025
| funcstr, Py_TYPE(args)->tp_name); | ||
| Py_DECREF(funcstr); | ||
| } | ||
| _PyErr_Format(tstate, PyExc_TypeError, |
There was a problem hiding this comment.
Why not to use %T formatter here? IIUC it is preferable now.
There was a problem hiding this comment.
Nikita's suggestions on removing the function name entirely were motivated by the fact that getting this name is not fast and does not add much value (in fact, none at all). I've looked into the %T specification, and it seems to do x2 of work we just got rid of, so I doubt that that would be a positive change. Anyway, we're waiting on Mark's review on that, maybe he has another opinion
sobolevn
reviewed
Jul 8, 2025
Comment on lines
+331
to
332
| TypeError: Value after ** must be a mapping, \ | ||
| not function |
There was a problem hiding this comment.
Suggested change
| TypeError: Value after ** must be a mapping, \ | |
| not function | |
| TypeError: Value after ** must be a mapping, not function |
Please, fix similar cases :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved removing function name from error message entirely