gh-154419: Find the fish shell in test_venv#154420
Merged
Merged
Conversation
shutil.which('fish') can find the unrelated "Go Fish" game, which is
shipped on several BSD systems. Search PATH for an executable which
behaves like the fish shell instead.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
serhiy-storchaka
enabled auto-merge (squash)
July 22, 2026 05:43
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15. |
|
Sorry, @serhiy-storchaka, I could not cleanly backport this to |
|
Sorry, @serhiy-storchaka, I could not cleanly backport this to |
|
Sorry, @serhiy-storchaka, I could not cleanly backport this to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
shutil.which('fish')can find the unrelated "Go Fish" game (see fish(6)), which is shipped on NetBSD, OpenBSD and DragonFly BSD. On DragonFly BSD/usr/gamesprecedes/usr/local/bininPATH, so the game is found even when the fish shell is installed.Search
PATHfor an executable which behaves like the fish shell instead. Verified with the fish shell installed on Linux, DragonFly BSD, NetBSD, OpenBSD and Solaris: the test now runs on all of them.