Skip to content

Speed up case sensitive is-file check in file system cache #10093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 15, 2021
Merged

Speed up case sensitive is-file check in file system cache #10093

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
20ba593
Speed up case sensitive is-file check in file system cache
JukkaL Feb 15, 2021
58c4f5f
Address feedback
JukkaL Feb 15, 2021
ace790a
Attempt to fix Windows
JukkaL Feb 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Attempt to fix Windows
  • Loading branch information
@JukkaL
JukkaL committed Feb 15, 2021
commit ace790ad867bccfb52c458a9244ea96a3a68f2cc
3 changes: 1 addition & 2 deletions mypy/fscache.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,11 +229,10 @@ def _exists_case(self, path: str, prefix: str) -> bool:
if path in self.exists_case_cache:
return self.exists_case_cache[path]
head, tail = os.path.split(path)
if not head.startswith(prefix):
if not head.startswith(prefix) or not tail:
# Only perform the check for paths under prefix.
self.exists_case_cache[path] = True
return True
assert tail
try:
names = self.listdir(head)
# This allows one to check file name case sensitively in
Expand Down