Fix daemon crash on malformed NamedTuple#14119
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
JukkaL
approved these changes
Nov 17, 2022
JukkaL
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, just left one idea about an additional thing to test.
| class C: ... | ||
| x: int | ||
| y: int | ||
| # change |
Collaborator
There was a problem hiding this comment.
Maybe also test a change in another module to test AST stripping and reprocessing of an invalid named tuple?
Member
Author
There was a problem hiding this comment.
Yeah, it actually doesn't work. This btw also affects the recent TypedDict PR too, I am going to fix both.
This comment has been minimized.
This comment has been minimized.
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
ChristianWitzler
added a commit
to ChristianWitzler/mypy
that referenced
this pull request
Nov 21, 2022
Fix daemon crash on malformed NamedTuple (python#14119)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14098
Having invalid statements in a NamedTuple is almost like a syntax error, we can remove them after giving an error (without further analysis). This PR does almost exactly the same as #13963 did for TypedDicts.