[mypyc] Optimize classmethod calls via cls#14789
Merged
Merged
Conversation
If the class has no subclasses, we can statically bind the call target. For this to be safe, also reject assignments to the "cls" argument in classmethods in compiled code. This makes the deltablue benchmark about 11% faster.
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Collaborator
Author
|
Note that we can't easily use vtables to call class methods, since vtables are accessible through instances, not type objects. |
jhance
approved these changes
Mar 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the class has no subclasses, we can statically bind the call target:
For this to be safe, also reject assignments to the "cls" argument in
classmethods in compiled code.
This makes the deltablue benchmark about 11% faster.