Fix ParamSpec inference for callback protocols#15986
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
This was referenced Aug 29, 2023
Closed
koogoro
approved these changes
Aug 29, 2023
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
hauntsaninja
approved these changes
Aug 30, 2023
koogoro
pushed a commit
that referenced
this pull request
Sep 2, 2023
Fixes #15984 Fix is straightforward, `ParamSpec` inference special-casing should put instances with `__call__` and callable types on same ground.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15984
Fix is straightforward,
ParamSpecinference special-casing should put instances with__call__and callable types on same ground.