tuple slice should not propagate fallback#16154
Merged
Merged
Conversation
Contributor
Author
|
I want to add #8776 (comment) as a test case, but I'm not sure where |
graingert
commented
Sep 21, 2023
|
|
||
| def slice(self, begin: int | None, end: int | None, stride: int | None) -> TupleType: | ||
| def slice( | ||
| self, begin: int | None, end: int | None, stride: int | None, *, fallback: Instance | None |
Contributor
Author
There was a problem hiding this comment.
fallback should always be named_type("builtins.tuple") but I'm not sure how to make one without access to a TypeChecker instance
graingert
marked this pull request as ready for review
September 21, 2023 13:47
This comment has been minimized.
This comment has been minimized.
hauntsaninja
approved these changes
Sep 30, 2023
hauntsaninja
left a comment
Collaborator
There was a problem hiding this comment.
Thanks, merge conflicts aside, this looks good to me. test-data/unit/check-tuples.test is probably a good place for the test you suggest.
Contributor
Author
|
@hauntsaninja ok conflicts resolved |
This comment has been minimized.
This comment has been minimized.
Collaborator
|
Tests are failing, let me know if you could use assistance on getting your nice #8776 (comment) example in a test |
graingert
commented
Oct 1, 2023
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
@hauntsaninja ok I added that test |
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8776
NamedTuple (or any other tuple subtype) slicing should not propagate the fallback