Add unimported-reveal error code#16271
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
ilevkivskyi
reviewed
Oct 17, 2023
ilevkivskyi
reviewed
Oct 17, 2023
ilevkivskyi
reviewed
Oct 17, 2023
ilevkivskyi
approved these changes
Oct 17, 2023
ilevkivskyi
left a comment
Member
There was a problem hiding this comment.
Generally looks good, but there are some suggestions on the docs.
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: vision (https://github.com/pytorch/vision): typechecking got 1.31x slower (44.0s -> 57.5s)
(Performance measurements are based on a single noisy sample)
|
Member
Author
|
Flaky macos + 3.8 build strikes agains :( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note:
reveal_type(1) # type: ignoreis problematic, because it silences the output. So, I've added some docs to advertise not doing so.Closes #16270