Fix crash on strict-equality with recursive types#16483
Conversation
This comment has been minimized.
This comment has been minimized.
AlexWaygood
left a comment
There was a problem hiding this comment.
LGTM. One very minor code-style nit below:
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Right before merging this, I noticed there is a very similar crash that this PR would not fix. It is a bit trickier to fix, but generally the logic is the same. Note btw that deciding whether two recursive types overlap is non-trivial, for example in the case with two different recursive |
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Fixes #16473 Potentially we can turn this helper function into a proper visitor, but I don't think it is worth it as of right now. --------- Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Fixes #16473
Potentially we can turn this helper function into a proper visitor, but I don't think it is worth it as of right now.