Don’t leak unreachability from lambda body to surrounding scope#17287
Merged
Conversation
andersk
commented
May 24, 2024
Contributor
- Fixes mypy does not check the code after the line with lambda function that calls NoReturn function #17254.
Fixes python#17254. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
This comment has been minimized.
This comment has been minimized.
andersk
force-pushed
the
lambda-noreturn
branch
2 times, most recently
from
May 24, 2024 21:14
7d15f32 to
2f3a09f
Compare
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
hauntsaninja
approved these changes
May 26, 2024
hauntsaninja
left a comment
Collaborator
There was a problem hiding this comment.
Looks good. The false positive should be easy to fix, I can open a PR
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.