Skip to content

Fix crash on recursive alias with an optional type #17350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ilevkivskyi merged 2 commits into from
Jun 9, 2024
Merged

Fix crash on recursive alias with an optional type #17350

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a7d495d
Fix crash on recursive alias with an optional type
ilevkivskyi Jun 9, 2024
ce033bd
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jun 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
[pre-commit.ci] auto fixes from pre-commit.com hooks 
for more information, see https://pre-commit.ci
  • Loading branch information
@pre-commit-ci
pre-commit-ci[bot] committed Jun 9, 2024
commit ce033bd598c999547542c73c682e02c80e4fbfa4
6 changes: 1 addition & 5 deletions mypy/typeanal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2340,11 +2340,7 @@ def make_optional_type(t: Type) -> Type:
return t
elif isinstance(t, ProperType) and isinstance(t, UnionType):
# Eagerly expanding aliases is not safe during semantic analysis.
items = [
item
for item in t.items
if not isinstance(get_proper_type(item), NoneType)
]
items = [item for item in t.items if not isinstance(get_proper_type(item), NoneType)]
return UnionType(items + [NoneType()], t.line, t.column)
else:
return UnionType([t, NoneType()], t.line, t.column)
Expand Down