Fix self-referential upper bound in new-style type variables#17407
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
JukkaL
approved these changes
Jun 20, 2024
JukkaL
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for fixing this! I couldn't remember how this all worked and was pretty confused when I briefly looked into this myself.
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17347
This copies old-style
TypeVarlogic 1:1 (I know it is ugly, but I don't think there is anything better now). Also while I am touching this code, I am removingthird_passargument (third pass is not a thing for ~5 years now).