Do not report plugin-generated methods with explicit-override#17433
Merged
Conversation
Member
Author
This comment has been minimized.
This comment has been minimized.
Collaborator
|
This PR looks similar (although with more tests) to #17370 which addresses the same issue. |
Member
Author
|
Thanks! Indeed, I will take a |
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes typeddjango/django-stubs#2226
Closes #17417
Closes #17370
Closes #17224
This is an alternative to #17418
Thanks a lot to @sterliakov, I took a dataclasses test case from #17370