[mypyc] feat: extend stararg fastpath from #19629 with star2 fastpath#19630
Merged
Conversation
BobTheBuidler
commented
Aug 13, 2025
This comment was marked as resolved.
This comment was marked as resolved.
Collaborator
Contributor
Author
|
You can disregard that comment. I was confused at the time but already addressed my own concern. |
JukkaL
reviewed
Aug 20, 2025
JukkaL
left a comment
Collaborator
There was a problem hiding this comment.
Thanks, looks good. Left a few comments about tests, and also can you check that there are run tests that cover this functionality (there may be pre-existing tests but I'm not sure)?
Contributor
Author
|
I added the same new test cases on both this PR and on #19631 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR further extends the stararg fastpath PRs (#19623 , #19629) with fastpath logic for star2
All 3 PRs were kept separate in order to make them easier to review and to make the changes in the IR more obvious in a diff. I will rebase this PR once #19623 and #19629 are merged.
This full series of PRs is ready for review.