Repository navigation
chore(e2e): pin Maestro via mise - #7511
Merged
Merged
Conversation
olerass
added a commit
that referenced
this pull request
Jul 20, 2026
We currently pin Node in two files (`.nvmrc` and `.node-version`) that can drift, Maestro sits separately in `.tool-versions`, and Ruby needs a manual rbenv/rvm setup of its own. Following on from #7511, the natural cleanup is to give mise full responsibility for tool versions. This change makes `mise install` the single setup step: * Maestro moves into `mise.toml` * `.nvmrc` is removed in favor of keeping only `.node-version` (see below why we can't use `mise.toml` just yet for Node) * Node and Ruby are wired in through mise's idiomatic version file support. They stay pinned in `.node-version`/`.ruby-version` since the CI actions `actions/setup-node` and `ruby/setup-ruby` don't support Mise yet * For Bitrise the community [`nvm@1`](https://github.com/almouro/bitrise-nvm-step) step, which silently falls back to installing the latest Node once `.nvmrc` is gone, is replaced with a script step that installs mise and Node from the same `.node-version` pin and exposes them to all subsequent steps. Once [actions/setup-node#1421](actions/setup-node#1421) ships we can fold the Node pin into `mise.toml` and drop `.node-version` for a single canonical pin file.
olerass
added a commit
that referenced
this pull request
Jul 31, 2026
Our Maestro E2E entry scripts carry two lines that no longer do anything. Both were load-bearing when the pipeline was written in #6478 (Apr 2025) and were stranded by later refactors: * the `PATH` export pointing at the Maestro curl installer's bin directory, obsolete since we switched to `jdx/mise-action` in #7511 (May 2026). Nothing creates that directory on the runners now * an `ARTIFACTS_FOLDER` default, left over from when these scripts handled artifacts themselves. It's assigned but never read, and never exported either, so the shared runner script that took that work over couldn't pick it up regardless This change deletes both. The workflow-level `ARTIFACTS_FOLDER` that the upload steps read is a separate thing and stays. Groundwork ahead of the Maestro 2.7.0 upgrade.
olerass
added a commit
that referenced
this pull request
Aug 4, 2026
CI installs Anvil through the foundry-toolchain action with `version: stable`. The action is SHA-pinned so the block reads as pinned at a glance, but the binary it fetches is whatever the newest foundry release happens to be. A foundry release can therefore change how our tests behave between one develop run and the next. It's also missing from local setup. `mise install` gives you Maestro but not anvil, so a fresh checkout can't run the transaction tests until you install foundry separately, and nothing keeps that version in step with CI. This change moves anvil into `mise.toml` alongside Maestro, following #7511, so a single pin covers CI and local and `mise install` is enough to run the suite. `1.7.1` is what `stable` resolves to today, so no behaviour change expected, and it drops an action from our supply chain. `install_args` names both tools rather than installing everything in the config, since we enable idiomatic version files for node and ruby and a bare `miseinstall` would pull those in and collide with `actions/setup-node`. Ref APP-3954
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Maestro version is currently hardcoded in our E2E workflows but has no equivalent pin locally. Local dev gets whatever Maestro brew or the curl install last fetched, which can drift from CI silently, and bumping the version means editing two places.
This change adds
.tool-versionsat the repo root as the single source of truth:jdx/mise-actionmise installThis is also an explicit first step towards standardizing our toolchain on Mise for managing tool deps. We'll do quick follow PRs that move Node, Ruby and others in here too and move away from recommending nvm and others. These can still be used ofc if need be, but is not the recommended setup going forward once those PRs land.