fix(tag-release): map fork RPC secrets to the env names foundry reads#285
Conversation
The verify step set env vars named after the secrets (RPC_URL_<NETWORK>_FORK),
but foundry.toml's [rpc_endpoints] read ${<NETWORK>_RPC_URL}. So the vars foundry
needs were unset and createSelectFork failed "environment variable
ARBITRUM_RPC_URL not found" (observed on rain.factory.deploy's release). Map each
secret to the <NETWORK>_RPC_URL name foundry expects, mirroring rainix-sol-test,
with the vars.* fallback.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Warning Review limit reached
Next review available in: 48 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Reviewed 97fbfc7: approve CodeRabbit rate-limited (not reviewing). Own review: the change maps each RPC_URL__FORK secret to the _RPC_URL env name foundry.toml reads, mirroring rainix-sol-test.yaml, with the vars.* fallback — trivially correct, and the exact fix for the createSelectFork 'env var not found' that failed rain.factory.deploy's verify. Green-by-rule: the only red is rainix-sol-artifacts, inherited from main (the eth-sepolia RPC-secret issue in #283/#284), unrelated to this env-name change. |
|
@coderabbitai assess this PR size classification for the totality of the PR with the following criterias and report it in your comment: S/M/L PR Classification Guidelines:This guide helps classify merged pull requests by effort and complexity rather than just line count. The goal is to assess the difficulty and scope of changes after they have been completed. Small (S)Characteristics:
Review Effort: Would have taken 5-10 minutes Examples:
Medium (M)Characteristics:
Review Effort: Would have taken 15-30 minutes Examples:
Large (L)Characteristics:
Review Effort: Would have taken 45+ minutes Examples:
Additional Factors to ConsiderWhen deciding between sizes, also consider:
Notes:
|
Fixes a real bug in
rainix-tag-release's verify step (introduced in #280, unchanged by #282), caught whenrain.factory.deploy's first release run failed.Bug
The verify step named its env vars after the secrets —
RPC_URL_ARBITRUM_FORK,RPC_URL_BASE_FORK, … — butfoundry.toml's[rpc_endpoints]read${ARBITRUM_RPC_URL},${BASE_RPC_URL}, …. So the vars foundry actually needs were never set, and every fork in the verify suite died with:The test reusable (
rainix-sol-test.yaml) maps them correctly; the tag-release verify step didn't. Until this lands, no tag-release can pass verify → nothing publishes.Fix
Map each
RPC_URL_<NETWORK>_FORKsecret to the<NETWORK>_RPC_URLenv name foundry expects (mirroringrainix-sol-test.yaml), with the|| vars.*fallback the rest of the org's CI uses. yamlfmt clean.🤖 Generated with Claude Code