Apply themes on startup if settings changed while VSCode was closed#22
Open
asrma7 wants to merge 1 commit into
Open
Apply themes on startup if settings changed while VSCode was closed#22asrma7 wants to merge 1 commit into
asrma7 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21.
updateThemes()is only called insideonDidChangeConfiguration, which doesn't fire on startup and only runs while VSCode is already open. So if an external tool like Matugen updatesmaterial-code.colorswhile VSCode is closed, the new colors are never applied on the next launch even thoughsettings.jsonis correct.This adds a settings hash check on activation. The hash covers the same four theme-related config keys already checked by
onDidChangeConfigurationand is persisted viaAppData. On startup, if the hash differs from the last session,updateThemes()runs in the background. The hash is also kept in sync insideonDidChangeConfigurationso subsequent cold starts don't redundantly rewrite the theme files.