This repository was archived by the owner on Feb 16, 2026. It is now read-only.
Support useRootClose inside open shadow roots#1004
Merged
kyletsang merged 3 commits intoJun 2, 2022
Conversation
This was referenced May 25, 2022
Contributor
Author
|
Lint errors should be fixed now. |
kyletsang
reviewed
May 31, 2022
kyletsang
approved these changes
Jun 2, 2022
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
useRootCloseshould inspectEvent.composedPath()so that it can react correctly to events coming from an open shadow root.In order to test this, it was also necessary to add a workaround for simulant which is creating events with
composed: falseby default.