Skip to content
This repository was archived by the owner on Feb 16, 2026. It is now read-only.

fix(usePopper): fix exported Modifier type#1013

Merged
kyletsang merged 5 commits into
react-bootstrap:masterfrom
iz-podpolja:master
Sep 16, 2022
Merged

fix(usePopper): fix exported Modifier type#1013
kyletsang merged 5 commits into
react-bootstrap:masterfrom
iz-podpolja:master

Conversation

@iz-podpolja

Copy link
Copy Markdown
Contributor

As per title, fixes: #1012

@kyletsang kyletsang changed the title Fixes #1012 fix(usePopper): fix exported Modifier type Sep 12, 2022
@kyletsang

Copy link
Copy Markdown
Member

Thanks for the PR. Could you run prettier on your code?

@iz-podpolja

Copy link
Copy Markdown
Contributor Author

Thanks for the PR. Could you run prettier on your code?

Sure - done.

@kyletsang

Copy link
Copy Markdown
Member

Thanks. Prettier looks good on the code, but we don't need those changes on the changelog

@kyletsang

Copy link
Copy Markdown
Member

There's also this error

Type 'undefined' does not satisfy the constraint 'Obj'.

@iz-podpolja

iz-podpolja commented Sep 13, 2022

Copy link
Copy Markdown
Contributor Author

There's also this error

Type 'undefined' does not satisfy the constraint 'Obj'.

Ok, excluded the changelog.md from prettier output and added a util to proxify undefined with Popper.Obj.
Tests, lint & tsc --noEmit are green for me.

@kyletsang
kyletsang merged commit 96b3425 into react-bootstrap:master Sep 16, 2022
@kyletsang

Copy link
Copy Markdown
Member

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

react-overlays won't compile with typescript 4.7+

2 participants