[Android] Add headers support when passing source array#32863
Open
marcesengel wants to merge 8 commits into
Open
[Android] Add headers support when passing source array#32863marcesengel wants to merge 8 commits into
marcesengel wants to merge 8 commits into
Conversation
Simplified code flow Removed native headers prop in favour of passing them in the src array
Contributor
|
Hopefully this is not irritating for them - but I requested review from @mdvacca and @yungsters - they appear to be the most recent editors in this area? Apologies in advance if that's a courtesy breach. Cheers all |
|
This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
Contributor
Author
|
Not stale 😖 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently passing headers in the
sourcearray of an<ImageView />is not supported on android becauseReadableMapprop, passed as-is to theReactNetworkImageRequest.fromBuilderWithHeaders. This means different headers per array entry are simply not possiblesource?.headerswhich clearly will not work when putting the headers into the source array (e.g.[ { headers: { Test: '123' }, uri: '...' } ]- this also showcases a workaround, just set theheadersproperty on your source array and you are good to go as long as you always need the same headers)Changelog
<Image />code flowheadersproperty into thesrcpropertyheadersproperty toImageSourceclass[Android] [Fix] - Support headers when passing an array for the
<Image />sourcepropertyTest Plan
CI tests should cover these changes.
Edit: Also confirmed working in a test project.