Fix adjustsFontSizeToFit on new arch

[janicduplessis]

Summary:

When using adjustsFontSizeToFit on Fabric the behavior is different from the old renderer. The text will grow bigger than the current font size while on the old renderer it won't. The minimumFontScale is also not implemented. The code currently uses minimumFontSize and maximumFontSize but those props do not actually exist.

This brings the behavior closer to the old renderer by removing the wrong props and implementing minimumFontScale instead. From what I understand in the old renderer it would use the font size of the outermost text, but since we don't easily have access to that in Fabric I use the maximum font size of the attributed string.

Changelog:

[IOS] [FIXED] - Fix adjustsFontSizeToFit on iOS Fabric

Test Plan:

This adds some example of the different behavior in RNTester

• You can see that on iOS fabric the line It doesn't grow grows bigger than its original font size
• You can see that on iOS and Android fabric the line Can limit how small the text becomes with minimumFontScale does not respect the minimumFontScale.

Before

Old renderer iOS:

Old renderer Android

Fabric iOS:

Fabric Android

After

Fabric iOS:

Fabric Android:

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	20,365,665	-96,525
android	hermes	armeabi-v7a	n/a	--
android	hermes	x86	n/a	--
android	hermes	x86_64	n/a	--
android	jsc	arm64-v8a	23,569,723	-90,354
android	jsc	armeabi-v7a	n/a	--
android	jsc	x86	n/a	--
android	jsc	x86_64	n/a	--

Base commit: 51e464f
Branch: main

[janicduplessis]

@sammy-SC Could you have a look at this?

[react-native-bot]

This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

[janicduplessis]

Can anyone look at this? Pretty sure this is still needed.

[cipolleschi]

Could you rebase on main and retest on a recent version?
Many things have changed since March... I'd also summon @NickGerleman which has far more context on text than myself.

[janicduplessis]

Sounds good, I do have a rebased version of this for 0.76 so afaik it might not have changed much since.

[DarkShtir]

Hello)
Any updates about this??

[cipolleschi]

@janicduplessis do you mind rebasing this PR? We can't import it the PR is not updated.
Or do you rather abandon this and open a new one, if that's ready?

[janicduplessis]

Hey @cipolleschi, I am currently on vacation, I will have a look when back to revive this pr.

[DarkShtir]

@janicduplessis Any updates??

[conner1reimers]

Thanks for your work @janicduplessis. I've opened a partial replacement PR that attempts to address the issue of minimumFontScale not being respected on iOS when used with adjustsFontSizeToFit: #54072.

[BasixKOR]

Sorry for the ping but it's been 10 months since the last update and I would appreciate if we could move forward with this PR or supersed this with another one.

[andveloper]

We would also be grateful if this could be resolved 🙏