chore(iOS): refactor RCTImageUtils, RCTTextView & RCTParagraphComponentView.mm to use UTType#46532
chore(iOS): refactor RCTImageUtils, RCTTextView & RCTParagraphComponentView.mm to use UTType#46532krozniata wants to merge 2 commits into
RCTImageUtils, RCTTextView & RCTParagraphComponentView.mm to use UTType#46532Conversation
cipolleschi
left a comment
There was a problem hiding this comment.
Thanks for this cleanup. I'll import it and 🤞 that the internal pipeline would like it!
|
Actually, CI is failing with It's likely that we have to add a framework to the React-RCTText.podspec file. |
|
Sure! |
|
@cipolleschi I've added missing framework, looks like everything builds correctly 🙌 |
|
@cipolleschi is there anything that needs to be done to get this PR merged? 👀 |
|
@krozniata nothing on your side. We need to wait for our internal partners that they migrate their apps away from iOS 13. I can check internally what's the status and let you know. |
|
@cipolleschi got it, thanks for update! |
|
This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
|
not stale |
|
This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
Summary:
This PR refactors
RCTImageUtils,RCTTextView&RCTParagraphComponentView.mmto use UTType because of deprecation warning from iOS 15 and aboveChangelog:
[IOS] [CHANGED] - Refactor
RCTImageUtils,RCTTextView&RCTParagraphComponentView.mmto use UTTypeTest Plan:
Make sure that
RNTesterbuilds and runs correctly