Skip to content

chore(iOS): refactor RCTImageUtils, RCTTextView & RCTParagraphComponentView.mm to use UTType#46532

Open
krozniata wants to merge 2 commits into
react:mainfrom
krozniata:use-uttype-api
Open

chore(iOS): refactor RCTImageUtils, RCTTextView & RCTParagraphComponentView.mm to use UTType#46532
krozniata wants to merge 2 commits into
react:mainfrom
krozniata:use-uttype-api

Conversation

@krozniata

Copy link
Copy Markdown
Contributor

Summary:

This PR refactors RCTImageUtils, RCTTextView & RCTParagraphComponentView.mm to use UTType because of deprecation warning from iOS 15 and above

Changelog:

[IOS] [CHANGED] - Refactor RCTImageUtils, RCTTextView & RCTParagraphComponentView.mm to use UTType

Test Plan:

Make sure that RNTester builds and runs correctly

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Sep 17, 2024

@cipolleschi cipolleschi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this cleanup. I'll import it and 🤞 that the internal pipeline would like it!

@cipolleschi

Copy link
Copy Markdown
Contributor

Actually, CI is failing with

ld: Undefined symbols:
 _UTTypeFlatRTFD, referenced from:
  -[RCTTextView copy:] in RCTTextView.o
   _UTTypeUTF8PlainText, referenced from:
      -[RCTTextView copy:] in RCTTextView.o
clang: error: linker command failed with exit code 1 (use -v to see invocation)
 Ld /Users/runner/Library/Developer/Xcode/DerivedData/HelloWorld-czqnsntrjgyngsfxcbfgwyssconw/Build/Intermediates.noindex/Pods.build/Release-iphonesimulator/React-RCTText.build/Objects-normal/arm64/Binary/RCTText normal arm64 (in target 'React-RCTText' from project 'Pods')

It's likely that we have to add a framework to the React-RCTText.podspec file.
Could you look into it?

@krozniata

Copy link
Copy Markdown
Contributor Author

Sure!

@krozniata

Copy link
Copy Markdown
Contributor Author

@cipolleschi I've added missing framework, looks like everything builds correctly 🙌

@krozniata

Copy link
Copy Markdown
Contributor Author

@cipolleschi is there anything that needs to be done to get this PR merged? 👀

@cipolleschi

Copy link
Copy Markdown
Contributor

@krozniata nothing on your side. We need to wait for our internal partners that they migrate their apps away from iOS 13. I can check internally what's the status and let you know.

@krozniata

Copy link
Copy Markdown
Contributor Author

@cipolleschi got it, thanks for update!

@react-native-bot

Copy link
Copy Markdown
Collaborator

This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@react-native-bot react-native-bot added Stale There has been a lack of activity on this issue and it may be closed soon. and removed Stale There has been a lack of activity on this issue and it may be closed soon. labels Sep 24, 2025
@krozniata

Copy link
Copy Markdown
Contributor Author

not stale

@react-native-bot

Copy link
Copy Markdown
Collaborator

This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@react-native-bot react-native-bot added Stale There has been a lack of activity on this issue and it may be closed soon. and removed Stale There has been a lack of activity on this issue and it may be closed soon. labels Apr 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants