@remotion/effects: Add scanlines effect - #7758
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Reviewed changes — Adding the scanlines() canvas effect to @remotion/effects, including WebGL2 shader implementation, package exports, validation, tests, documentation, and interactive demo.
- Add
scanlines()effect — WebGL2-based horizontal scanline overlay withamount,spacing,thickness,offset, andpremultiplyparameters - Register subpath export and bundle entrypoint —
package.jsonexports andbundle.tsupdated - Add validation and tests — Parameter validation with comprehensive test coverage for defaults, bounds, types, and effect key uniqueness
- Add documentation and demo — MDX docs page, sidebar entry, TOC preview, interactive demo component, and preview images
Kimi K2 ｜ 𝕏
Member
|
@pullfrog make the doc TOC alphabetic again |
Contributor
|
Fixed the effects doc TOC to be alphabetically sorted within each category again. The PR branch had new commits on the remote, so I rebased the fix on top of the latest Task list (4/4 completed)
|
JonnyBurger
requested changes
May 28, 2026
JonnyBurger
left a comment
Member
There was a problem hiding this comment.
- packages/docs/static/img/effects-scanlines-preview.png: effect is not visible, might need increase of example component
- effect is not added in alphabetic order in docs sidebar
samohovets
force-pushed
the
scanlines-effect-7619
branch
from
May 28, 2026 16:37
c2c6990 to
a68e0ee
Compare
samohovets
force-pushed
the
scanlines-effect-7619
branch
from
May 28, 2026 16:38
a68e0ee to
c2c6990
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scanlines()to@remotion/effectsFixes #7619.
Test plan
cd packages/effects && bun test src/testbun run buildbun run formattingbun run build-docs