@remotion/studio: Avoid re-registering timeline keybindings on selection change - #7843
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes — avoids re-registering timeline Backspace and Cmd/Ctrl+A keybindings on every selection change by reading mutable selection state through a ref instead of depending on it in useEffect.
TimelineDeleteKeybindings— removesselectedItems/clearSelectionfromuseEffectdeps; reads latest selection viacurrentSelection.currentinside the keybinding callback.TimelineSelectAllKeybindings— removesselectableSequenceSelections/selectItemsfromuseEffectdeps; reads latest selections via ref.TimelineSelectionProvider— wraps children in a newCurrentTimelineSelectionContextthat exposes the full context value as a ref, paired with a newuseCurrentTimelineSelectionStateAsRefconsumer hook.
Clean, focused perf improvement with no behavioral change.
Kimi K2 | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Avoids re-registering the timeline
Backspace(delete) andCmd/Ctrl+A(select-all) keybinding handlers every time the timeline selection changes.Previously,
TimelineDeleteKeybindingsandTimelineSelectAllKeybindingsdepended onselectedItems/selectableSequenceSelections/selectItems/clearSelectionin theiruseEffects, which caused the keybindings to be unregistered and re-registered on every selection mutation.The latest selection state is now read through a new
useCurrentTimelineSelectionStateAsRefhook, which exposes the up-to-date context value via a ref. The effects no longer depend on the changing selection, so the keybindings are registered once and stay registered while the provider is mounted.Test plan
Backspace— items still get deletedCmd/Ctrl+Ain the timeline — all selectable items get selected