Skip to content

New package: @remotion/rough-notation - #9018

Merged
JonnyBurger merged 79 commits into
mainfrom
codex/add-rough-notation-package
Jul 15, 2026
Merged

New package: @remotion/rough-notation#9018
JonnyBurger merged 79 commits into
mainfrom
codex/add-rough-notation-package

Conversation

@JonnyBurger

@JonnyBurger JonnyBurger commented Jul 11, 2026

Copy link
Copy Markdown
Member

TODO:

  • Add to skills
  • Show posterization in /docs/text-highlights
  • Mention randomizing seed
  • Add more examples in /docs/text-highlights

@vercel

vercel Bot commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
bugs Ready Ready Preview, Comment Jul 15, 2026 1:58pm
remotion Ready Ready Preview, Comment Jul 15, 2026 1:58pm

Request Review

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

One correctness issue to address before merging: the annotation renderer can produce duplicate React keys whenever iterations draws the same path, so React drops the duplicates and only one iteration renders.

Reviewed changes — This PR adds a new @remotion/rough-notation package with rough annotation components, docs, and example compositions to Remotion.

  • Add @remotion/rough-notation package with createAnnotation(), <AnnotationBehind>, <AnnotationOnTop>, and annotationConfig.
  • Add documentation pages for the new APIs under docs/docs/rough-notation/.
  • Register six example compositions in packages/example/src/RoughNotation.
  • Wire the package into the monorepo via package.json, bun.lock, tsconfig.json, sidebars.ts, and package lists.

Pullfrog  | Fix all ➔Fix 👍s ➔View workflow run | Using Kimi K2 (free via Pullfrog for OSS) | 𝕏

Comment thread packages/rough-notation/src/render-annotation.tsx Outdated
Comment thread packages/docs/docs/rough-notation/index.mdx Outdated
Comment thread packages/docs/docs/rough-notation/annotation-behind.mdx Outdated
Comment thread packages/docs/docs/rough-notation/annotation-on-top.mdx Outdated
Comment thread packages/docs/docs/rough-notation/annotation-config.mdx Outdated
Comment thread packages/docs/docs/rough-notation/create-annotation.mdx Outdated

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incremental review of the latest commits. The Interactive/Sequence integration and the split examples are nice improvements. However, the duplicate React key issue in packages/rough-notation/src/render-annotation.tsx still needs a fix; the new Box.tsx example now directly demonstrates the problem with iterations={2}. I’m also withdrawing my earlier AvailableFrom version comment — pointing new docs to the next patch version (4.0.489) matches Remotion’s convention.

Pullfrog  | Fix it ➔View workflow run | Using Kimi K2 (free via Pullfrog for OSS) | 𝕏

@vercel
vercel Bot temporarily deployed to Preview – remotion July 14, 2026 08:44 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant