@remotion/studio: Move keyframe settings to easing inspector - #9065
Merged
Conversation
Contributor
There was a problem hiding this comment.
ℹ️ No critical issues — one minor UX suggestion inline.
Reviewed changes — moves keyframe extrapolation, output, and posterize controls out of the modal and into the easing inspector, switching them to immediate save and removing the context-menu entries that previously opened the modal.
EasingInspector.tsxnow requires a non-nulleasingUpdateand renders<KeyframeSettings update={easingUpdate} />inline.KeyframeSettings.tsxis a new inline control panel replacing the deletedKeyframeSettingsModal.tsx.Modals.tsxandpackages/studio/src/state/modals.tsremove thekeyframe-settingsmodal type.TimelineEffectPropItem.tsxandTimelineSequencePropItem.tsxremove theModalsContextwiring and theKeyframe settings...context-menu item.
Kimi K2 (free via Pullfrog for OSS) | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Testing
bunx turbo run make --filter='@remotion/studio'bunx turbo run lint test --filter='@remotion/studio'bun run buildbun run stylecheckCloses #8960