Skip to content

@remotion/studio: Open assets in new window - #9369

Merged
JonnyBurger merged 1 commit into
mainfrom
codex/asset-open-new-window-9365
Jul 21, 2026
Merged

@remotion/studio: Open assets in new window#9369
JonnyBurger merged 1 commit into
mainfrom
codex/asset-open-new-window-9365

Conversation

@JonnyBurger

Copy link
Copy Markdown
Member

Summary

  • add an "Open in new window" action to asset selector context menus
  • share the existing centered popup behavior between assets and compositions
  • cover Studio route opening and popup positioning with a regression test

Testing

  • bun test src in packages/studio (452 tests passed)
  • bun run build
  • bun run stylecheck

Closes #9365

@vercel

vercel Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
bugs Ready Ready Preview, Comment Jul 21, 2026 5:40am
remotion Ready Ready Preview, Comment Jul 21, 2026 5:40am

Request Review

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes — add an "Open in new window" action to asset selector context menus, extract the existing centered-popup logic from CompositionSelectorItem into a shared getOpenInNewWindowMenuItem helper, and cover the shared helper with a unit test.

  • Add "Open in new window" item for assets in AssetSelectorItem — reuses the shared helper with an /assets/${relativePath} route, consistent with existing asset navigation.
  • Extract shared popup helper into open-in-new-window.ts — preserves the existing centering math and getUrlForRoute query-string handling for read-only studios.
  • Add regression test open-in-new-window.test.ts — verifies route resolution and popup dimensions/positioning with a mocked window.

Pullfrog  | Fix it ➔View workflow run | Using Kimi K2 (free via Pullfrog for OSS) | 𝕏

@JonnyBurger
JonnyBurger merged commit 743e62d into main Jul 21, 2026
19 checks passed
@JonnyBurger
JonnyBurger deleted the codex/asset-open-new-window-9365 branch July 21, 2026 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Right-clicking an asset in asset selector should also have "Open in new window"

1 participant