@remotion/studio: Open assets in new window - #9369
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes — add an "Open in new window" action to asset selector context menus, extract the existing centered-popup logic from CompositionSelectorItem into a shared getOpenInNewWindowMenuItem helper, and cover the shared helper with a unit test.
- Add "Open in new window" item for assets in
AssetSelectorItem— reuses the shared helper with an/assets/${relativePath}route, consistent with existing asset navigation. - Extract shared popup helper into
open-in-new-window.ts— preserves the existing centering math andgetUrlForRoutequery-string handling for read-only studios. - Add regression test
open-in-new-window.test.ts— verifies route resolution and popup dimensions/positioning with a mockedwindow.
Kimi K2 (free via Pullfrog for OSS) | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Testing
bun test srcinpackages/studio(452 tests passed)bun run buildbun run stylecheckCloses #9365