@remotion/studio: Make pasting keyframes easier - #9430
Merged
Conversation
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes — PR adds an optional field identity to keyframe clipboard payloads and uses it to paste copied keyframes onto the matching sequence property when a sequence row is selected, while keeping older payloads that omit field valid.
KeyframeClipboardFieldtype and validation —packages/studio-shared/src/keyframe-clipboard-data.tsnow carries afielddiscriminator and rejects malformed identities.- Clipboard generation —
packages/studio/src/components/Timeline/keyframe-clipboard.tsrecordsfield.type/fieldKeywhen copying keyframes. - Paste targeting — when exactly one sequence row is selected and the payload identifies a sequence property, the selection is converted to the matching
sequence-propbefore resolving the paste target. - Tests — parser coverage for invalid field identities and a new test for pasting onto a selected sequence row; existing copy expectations updated.
Local verification passed for the files in scope: bun test, bunx turbo run make, formatting, and lint on @remotion/studio-shared and @remotion/studio.
Kimi K2 (free via Pullfrog for OSS) (Claude Opus not used — the program covers this model; add its provider key to run your pick) | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Testing
bun test packages/studio-shared/src/test/keyframe-clipboard-data.test.ts packages/studio/src/test/timeline-selection.test.tsbun run buildbun run stylecheckCloses #9392