@remotion/media: Buffer audio based on duration - #9453
Merged
Conversation
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes — Replaced the audio startup buffering heuristic in @remotion/media from a fixed chunk count to a duration-based threshold, so files with large PCM chunks (e.g. Live Photos) no longer deadlock waiting for six chunks before playback unblocks.
- Switched
onScheduledfrom receivingtimelineTimestampto accumulatingsourceDurationInSeconds. - Added
MINIMUM_AUDIO_BUFFERING_TIME_SECONDS/hasEnoughAudioToStartPlaybackand an idempotentunblockPlaybackhelper. - Updated the audio iterator manager test harness to parameterize the source URL and count unblock calls.
- Added a PCM regression test using
/junk.wavthat verifies playback unblocks after ~0.14s / three chunks rather than waiting for six chunks or EOF.
Kimi K2 (free via Pullfrog for OSS) (Claude Opus not used — the program covers this model; add its provider key to run your pick) | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Closes #9394
Tests
bunx vitest src/test/audio-iterator.test.ts --browser --run(10 tests)bun run buildbun run stylecheck